Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.7%. Comparing base (45e0b8b) to head (7d31a87).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##            main   #6378     +/-   ##
=======================================
- Coverage   68.7%   68.7%   -0.1%     
=======================================
  Files        200     200             
  Lines      16873   16883     +10     
=======================================
+ Hits       11602   11608      +6     
- Misses      4927    4930      +3     
- Partials     344     345      +1     

@dmathieu would you be able to re-approve this? I updated it against main

@dmathieu would appreciate another approval - I think last time you might have forgotten to hit the button, because I didn't see a new approval after you thumbsup'd my comment

I'm approving the CI. But you don't need another PR approval from me. We do need an approval from another approver though.

@dmathieu ooh, I see. I also finally discovered the issue with the CHANGELOG validation so that should stop failing now.

It looks like the error messages are different on windows versus linux, do you have any suggestions on how to update the tests? Should I be doing something like:

if runtime.GOOS == "windows" {
   wantErr = "error 1"
} else {
   wantErr = "error 2"
}

?

How about using assert.ErrorContains with the substring that matches all platforms?

@dmathieu alright how's that?

@dmathieu does something need to be done to get the CI going?

Also @pellared looks like the PR requires an approval from you?

All PRs require approval from two approvers/maintainers. So we're missing one.

Partially addresses #6351

What is missing?

HeadersList. I was told not to include that in this PR.

Please update the branch (sync with main)

ok